Add optimistic locking to Fedora #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escowles
reviewed
Aug 3, 2018
| # @note Fedora's last modified response is not granular enough to produce an effective lock token | ||
| # therefore, we use the same implementation as the memory adapter. This could fail to lock a | ||
| # resource if Fedora updated this resource between the time it was saved and Valkyrie created | ||
| # the token. |
There was a problem hiding this comment.
I appreciate the need for finer-grained locking than Fedora's HTTP-date based 1-second granularity. But maybe we should fall back on that, so we had at least that much protection against updates from non-Valkyrie clients?
There was a problem hiding this comment.
8/6/18: We decided that the current implementation is good enough to close this ticket, and created a separate ticket for using Fedora's If-Unmodified-Since header (#522)
hackartisan
force-pushed
the
i#454-fedora-adapter
branch
2 times, most recently
from
095769e
to
629fb6e
Compare
fixes #454 Co-authored-by: Trey Pendragon <[email protected]> Co-authored-by: Anna Headley <[email protected]> Co-authored-by: Carolyn Cole <[email protected]>
hackartisan
force-pushed
the
i#454-fedora-adapter
branch
from
629fb6e
to
2c11226
Compare
hackartisan
changed the title
escowles
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #454